Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix liblttng-ust0 to be liblttng-ust1 if supported #1585

Closed
wants to merge 1 commit into from
Closed

Fix liblttng-ust0 to be liblttng-ust1 if supported #1585

wants to merge 1 commit into from

Conversation

myoung34
Copy link

@myoung34 myoung34 commented Jan 4, 2022

Resolves #1584

Upcoming debian releases are going to use liblttng-ust1 instead of liblttng-ust0

This gives it some backwards compatible breathing room as a compatibility check

@myoung34 myoung34 requested a review from a team as a code owner January 4, 2022 03:06
@myoung34 myoung34 mentioned this pull request Jan 4, 2022
Merged
@myoung34
Copy link
Author

bump @TingluoHuang (I saw you approved similar changes elsewhere)

@myoung34
Copy link
Author

I've now been testing this in a gross way but can confirm it works as expected

root@41bff96ddd6f:/actions-runner# dpkg -l | grep ust
ii  liblttng-ust-common1:arm64    2.13.1-1                          arm64        LTTng 2.0 Userspace Tracer (common library)
ii  liblttng-ust-ctl5:arm64       2.13.1-1                          arm64        LTTng 2.0 Userspace Tracer (trace control library)
ii  liblttng-ust1:arm64           2.13.1-1                          arm64        LTTng 2.0 Userspace Tracer (tracing libraries)

Running as a runner:

docker pull myoung34/github-runner:debian-sid
docker run  \
  -e REPO_URL="https://github.com/octokode/test1" \
  -e RUNNER_NAME="foo-runner" \
  -e RUNNER_TOKEN="redact" \
  myoung34/github-runner:debian-sid

Runner reusage is disabled
Configuring

--------------------------------------------------------------------------------
|        ____ _ _   _   _       _          _        _   _                      |
|       / ___(_) |_| | | |_   _| |__      / \   ___| |_(_) ___  _ __  ___      |
|      | |  _| | __| |_| | | | | '_ \    / _ \ / __| __| |/ _ \| '_ \/ __|     |
|      | |_| | | |_|  _  | |_| | |_) |  / ___ \ (__| |_| | (_) | | | \__ \     |
|       \____|_|\__|_| |_|\__,_|_.__/  /_/   \_\___|\__|_|\___/|_| |_|___/     |
|                                                                              |
|                       Self-hosted runner registration                        |
|                                                                              |
--------------------------------------------------------------------------------

# Authentication


√ Connected to GitHub

# Runner Registration




√ Runner successfully added
√ Runner connection is good

# Runner settings


√ Settings Saved.


√ Connected to GitHub

Current runner version: '2.286.1'
2022-01-23 17:19:42Z: Listening for Jobs

@thboop thboop self-requested a review March 7, 2022 14:06
@myoung34
Copy link
Author

myoung34 commented Apr 4, 2022

cc @thboop @TingluoHuang

@WoodyWoodsta
Copy link

What is the hold back on this one? As a result, I'm having to downgrade to 20.04.

This was referenced Jun 10, 2022
Merged
Closed
@icedream
Copy link

Using Ubuntu 22.04 (current LTS!) triggers this issue at the moment.

@myoung34
Copy link
Author

Not sure how to get anyone to see this PR currently but the patch has been working on mine for months now

@WoodyWoodsta WoodyWoodsta mentioned this pull request Jun 12, 2022
Closed
@tuukkalahti tuukkalahti mentioned this pull request Jun 15, 2022
Merged
@tuukkalahti
Copy link
Contributor

Should be solved by #1946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thboop thboop Awaiting requested review from thboop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation updates around liblttng-ust0
5 participants
@myoung34 @WoodyWoodsta @icedream @tuukkalahti @TingluoHuang